-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduced cohomology+Eilenberg-Steenrod axioms #955
Conversation
I think the definition of |
Wups! Thanks for pointing this out. I'll fix it in a separate PR as soon as Anders merges this one (and the Gysin one since it depends on this one). |
Same here. It still checks on current master, if you change "--experimental-lossy-unification" to "--lossy-unification". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff - I only have organisational comments and one fix.
@aljungstrom Can you fix @felixwellen's comments and then we can merge? We should not forget to add the missing fields that @rwbarton pointed out as well |
Merging this now. @aljungstrom please make a new PR adding the two missing fields from |
This PR contains: